Flac Album Art craches?

[Breepee]

Hey,
I’ve got an album in FLAC format with albumart added (with MP3Tag) which would crash Firefly when I chose to play said files. At first I thought it didn’t work because of the FLAC encoder version (although it said 1.1.2, the forums mention the problem of encoder version a lot so I thought why not try reencoding with the latest version 1.1.4). At first it seemed to work, but then I hadn’t added the albumart yet. When I added the cover, it showed the same old behaviour again: crash upon play (I would never hear anything, as soon as I doubleclicked, Firefly crashed).

Here’s the log:

2007-06-19 13:27:24 (838327e8): Firefly Version svn-1498: Starting with debuglevel 2

2007-06-19 13:27:24 (838327e8): Starting rendezvous daemon

2007-06-19 13:27:24 (838327e8): Building drive mapping table from G:Program FilesFirefly Media Servermapping.ini

2007-06-19 13:27:24 (838327e8): Initializing database

2007-06-19 13:27:27 (838327e8): Starting web server from G:Program FilesFirefly Media Serveradmin-root on port 9999

2007-06-19 13:27:27 (838327e8): Registering rendezvous names

2007-06-19 13:27:27 (838327e8): Serving 12371 songs.  Startup complete in 3 seconds

2007-06-19 13:27:27 (838327e8): Rescanning database

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: daap.songalbumartist

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: daap.songcategory

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: daap.songextradata

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: daap.songcontentdescription

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: daap.songlongcontentdescription

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: daap.songkeywords

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: com.apple.itunes.is-podcast

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: com.apple.itunes.mediakind

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: com.apple.itunes.series-name

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: com.apple.itunes.network-name

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: com.apple.itunes.episode-num-str

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: com.apple.itunes.episode-sort

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: com.apple.itunes.season-num

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: daap.songgapless

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: com.apple.itunes.gapless-enc-del

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: com.apple.itunes.gapless-heur

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: com.apple.itunes.gapless-enc-dr

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: com.apple.itunes.gapless-dur

2007-06-19 13:27:32 (cc1642d3): Unknown meta code: com.apple.itunes.gapless-resy

2007-06-19 13:27:43 (cc1642d3): Unknown meta code: com.apple.itunes.is-podcast-playlist

2007-06-19 13:27:43 (cc1642d3): Unknown meta code: com.apple.itunes.special-playlist

2007-06-19 13:27:48 (838327e8): Starting playlist scan

2007-06-19 13:27:48 (838327e8): Processing static playlist: C:muziekspeellijstenVice City.m3u

2007-06-19 13:27:48 (838327e8): Processing static playlist: C:muziekspeellijstenRolling Stones Selectie.m3u

2007-06-19 13:27:48 (838327e8): Processing static playlist: C:muziekspeellijstenPositieve Beat.m3u

2007-06-19 13:27:48 (838327e8): Processing static playlist: C:muziekspeellijstenPeter Gabriel Selectie.m3u

2007-06-19 13:27:48 (838327e8): Processing static playlist: C:muziekspeellijstenMichael Jackson Selectie.m3u

2007-06-19 13:27:48 (838327e8): Processing static playlist: C:muziekspeellijstenFilmmuziek selectie.m3u

2007-06-19 13:27:48 (838327e8): Processing static playlist: C:muziekspeellijstenElvis Presley Selectie.m3u

2007-06-19 13:27:48 (838327e8): Processing static playlist: C:muziekspeellijstenElektronische sferen.m3u

2007-06-19 13:27:48 (838327e8): Processing static playlist: C:muziekspeellijstenDire Straits Selectie.m3u

2007-06-19 13:27:51 (838327e8): Updating playlists

2007-06-19 13:27:51 (838327e8): Scanned 12371 songs (was 12371) in 24 seconds

2007-06-19 13:27:52 (d6caebda): Session 0: Streaming file 'Tom Petty - Greatest Hits - 17 - Into The Great White Open.flac' to 10.0.0.150 (offset 0)

It’s an old version of Firefly, I know, but build 1586 shows the same behaviour, and that version doesn’t scan my m3u-playlists anymore!

[rpedde]

@Breepee wrote:

I’ve got an album in FLAC format with albumart added (with MP3Tag) which would crash Firefly when I chose to play said files. At first I thought it didn’t work because of the FLAC encoder version (although it said 1.1.2, the forums mention the problem of encoder version a lot so I thought why not try reencoding with the latest version 1.1.4). At first it seemed to work, but then I hadn’t added the albumart yet. When I added the cover, it showed the same old behaviour again: crash upon play (I would never hear anything, as soon as I doubleclicked, Firefly crashed).

If you don’t have the ffmpeg transcoder (and you shouldn’t), then it has to be an issue with flac, the command line decoder. Will flac decode it properly to a wav?

Otherwise, it doesn’t touch the file… it just hands it off to flac and pushes the output to the client.

It’s an old version of Firefly, I know, but build 1586 shows the same behaviour, and that version doesn’t scan my m3u-playlists anymore!

Double check your settings for scanning/enable_playlists, scanning/enable_m3u, etc. The options for scanning playlists changed somewhere back, and it might be defaulting the wrong way.

— Ron

[Breepee]

@rpedde wrote:

[..]

If you don’t have the ffmpeg transcoder (and you shouldn’t), then it has to be an issue with flac, the command line decoder. Will flac decode it properly to a wav?

Otherwise, it doesn’t touch the file… it just hands it off to flac and pushes the output to the client.

Files are encoded with binairies from flac.sourceforge.net. They decode perfectly in other apps and with flac itself too.

What do you exactly mean by having the ffmpeg transcoder? You mean in Firefly or using it to encode flac’s? I installed Firefly as-is, no changes whatsoever.

[rpedde]

@Breepee wrote:

@rpedde wrote:

[..]

If you don’t have the ffmpeg transcoder (and you shouldn’t), then it has to be an issue with flac, the command line decoder. Will flac decode it properly to a wav?

Otherwise, it doesn’t touch the file… it just hands it off to flac and pushes the output to the client.

Files are encoded with binairies from flac.sourceforge.net. They decode perfectly in other apps and with flac itself too.

What do you exactly mean by having the ffmpeg transcoder? You mean in Firefly or using it to encode flac’s? I installed Firefly as-is, no changes whatsoever.

Is this windows?

[Breepee]

Yes sir, see log 😉

[rpedde]

@Breepee wrote:

Yes sir, see log 😉

hrm… maybe I thought you had a G: drive on your linux box.

Yeah, it’s the version of ffmpeg I have. The version I have compiled with the windows distro is the last one I could find that actually *compiled* on win32. Since then, they’ve been bickering about windows on the mailing lists rather than actually trying to make it compile on windows.

I tried again a few months ago to see if anything was compilable yet, but it wasn’t. I can look again.

[Breepee]

So if I understand correctly, the problem lies with ffmpeg. Is there a way to circumvent this?

I hope you can fix this the next release then.

[Anonymous]

Okay, more than an year and this bug still exists? 🙁

Cover Art with mp3tag or dBPowerAmp screws up Firefly, mp3tag crashes the service and dBPowerAmp simply skips the file.

Any fixes or workarrounds?

[mscox_au]

@rpedde wrote:

@Breepee wrote:

Yes sir, see log 😉

hrm… maybe I thought you had a G: drive on your linux box.

Yeah, it’s the version of ffmpeg I have. The version I have compiled with the windows distro is the last one I could find that actually *compiled* on win32. Since then, they’ve been bickering about windows on the mailing lists rather than actually trying to make it compile on windows.

I tried again a few months ago to see if anything was compilable yet, but it wasn’t. I can look again.

G’day Ron, unfortunately I’ve just finished a grueling few weeks re-tagging all my flacs so they are nice, neat, tidy and consistent with my mp3 collection – however this also included the common practice of tagging album art. To cut a long story short, many of my flacs now no longer stream via firefly. I know you’re snowed under at the moment but I’d really appreciate it if you could look into recompiling the latest ffmpeg for transcoding that doesn’t crash on my (now newly retagged) flac files.

Thanks, Michael

Addendum: It does not appear to be the album-art per-se that is causing all the issues. In particular there are songs that play and have an album picture tag and there are songs that won’t, even if I clear that tag completely. I somewhat stumped as to what specifically is causing firefly to crash when attempting to recode but will let you know if I figure it out.

p.s. Ok, the problem appears to be a buffer overflow within ffmpeg whilst processing the OGG-FLAG tags. If the total size of the tags (including padding) exceeds some magic number (yet to be determined, but I suspect it is around either 16kb or 32kb) it crashes, bringing down firefly with it. The hack to workaround it is to completely remove all tags (using metaflac or the flac-gui) and then just re-tag basic information and album art to each file. I’d prefer a perma-fix though if possible.

[Author]

Posts