daapd is crashing while scanning

[Denis]

Hi

mt-daapd seems to crash when the extension of a filename is only a return or linefeed. Don’t ask me how this can happen but mt-daapd should not crash then.

then mt-daapd got in my freebsd sources and crashed, here the log:

2006-07-29 00:05:28 (08097000): Found /usr/src/sys/i386/compile/SONIC/modules/usr/src/sys/modules/3dfx
2006-07-29 00:05:28 (08097000): Found 3dfx.. recursing
2006-07-29 00:05:28 (08097000): Found /usr/src/sys/i386/compile/SONIC/modules/usr/src/sys/modules/3dfx/@
2006-07-29 00:05:28 (08097000): Found @.. recursing
2006-07-29 00:05:28 (08097000): Processing rendezvous message
2006-07-29 00:05:28 (08097000): Rendezvous socket closed (daap server crashed?) Aborting.
2006-07-29 00:05:28: Aborting

the dir looks like this:

drwxr-xr-x 2 root wheel 512 Feb 8 2005 .
drwxr-xr-x 240 root wheel 4096 Feb 7 2005 ..
-rw-r–r– 1 root wheel 1846 Feb 8 2005 .depend
lrwxr-xr-x 1 root wheel 12 Feb 7 2005 @ -> /usr/src/sys
-rw-r–r– 1 root wheel 24651 Feb 7 2005 bus_if.h
-rw-r–r– 1 root wheel 9879 Feb 7 2005 device_if.h
lrwxr-xr-x 1 root wheel 25 Feb 7 2005 machine -> /usr/src/sys/i386/include
-rw-r–r– 1 root wheel 19 Feb 7 2005 opt_tdfx.h
-rw-r–r– 1 root wheel 4641 Feb 7 2005 pci_if.h

Denis

PS: Iam using mt-daapd svn-1315 on freebsd 6.1

[rpedde]

@Denis wrote:

PS: Iam using mt-daapd svn-1315 on freebsd 6.1

Yeah, that seems not right. thanks for the heads-up.

— Ron

[Denis]

Hi

The second crash comes when mt-daapd follows the softlink back to the start. that creates an infinite loop which results in a stack overflow after some time. You should follow every link only ones.

Denis

[Denis]

Hi

mt-daapd crashes when there is a file with no extension but ends with a dot, like:

bla.
song.
thiswasasong.

Denis

[Denis]

simply change

if(ext)

to

if(ext && strlen(ext) >=4)

in ca. line 577 in mp3-scanner.c.
that fixes the last bug.

Denis

[rpedde]

@Denis wrote:

ner.c.
that fixes the last bug.

Fixed in svn

[Author]

Posts