Reply To: svn-1659 crashes when SB tries to access

#12554
rpedde
Participant

@RobotChicken wrote:

Crash reason (?):
http://mt-daapd.svn.sourceforge.net/viewvc/mt-daapd/trunk/src/util.c?r1=1633&r2=1634&view=diff&diff_format=l

(1) In OpenBSD (what I am using) there is va_copy() but the it does not get picked up by util.c (no HAVE_*VA_COPY macros?)
(2) I think

VA_COPY(a,b) memcpy((a),(b),sizeof(b))

should be

VA_COPY(a,b) memcpy((&a),(&b),sizeof(b))

Oh, duh. No wonder I couldn’t find it in any of the arches I have — it’s not arch dependent, it’s arch and os dependent.

Have you verified that the patch works?

Also, can you research to see where va_copy is defined, and what the define is that’s making it not detect?

Or failing that, can you find the header that defines va_copy and email it to me?

([email protected])

thanks.

— Ron